Project

General

Profile

Enhancement #34

Compiling ua with BUILD_TYPE=user

Added by Jean Yves BAUDY almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Low
Target version:
% Done:

90%

Device:

Description

Hi There,

First thanks for taking into account my previouis "issues".

For version 6.0.1 the last code I need to chage to have "a pure user" build rom not detected by my work secutiry application is this code.

diff --git a/products/ua_espresso3g.mk b/products/ua_espresso3g.mk
index 99f543c..c9b9296 100644
--- a/products/ua_espresso3g.mk
+++ b/products/ua_espresso3g.mk
@@ -28,4 +28,6 @@ PRODUCT_MANUFACTURER := Samsung
 PRODUCT_BUILD_PROP_OVERRIDES += \
     PRODUCT_NAME=espresso10rfxx \
     BUILD_FINGERPRINT="samsung/espresso10rfxx/espresso10rf:4.2.2/JDQ39/P5100XXDNA1:user/release-keys" \
-    PRIVATE_BUILD_DESC="espresso10rfxx-user 4.2.2 JDQ39 P5100XXDNA1 release-keys"
+    PRIVATE_BUILD_DESC="espresso10rfxx-user 4.2.2 JDQ39 P5100XXDNA1 release-keys" \
+    BUILD_DISPLAY_ID=${BUILD_ID} \
+    BUILD_VERSION_TAGS=release-keys

 

This is bad a this code is hardcoded. Maybe the properties generated in build.props must take into account the BUILD_TYPE params.

 

Regards

 

History

#1 Updated by Andreas Blaesius almost 2 years ago

Are you sure it's not only because of testkeys? You might want to switch to a private key.

Maybe follow https://wiki.lineageos.org/signing_builds.html to.sign your builds

#2 Updated by Jean Yves BAUDY almost 2 years ago

Andreas Blaesius wrote:

Are you sure it's not only because of testkeys? You might want to switch to a private key.

Maybe follow https://wiki.lineageos.org/signing_builds.html to.sign your builds

Hi

The internal security check application consider that the device is not rooted just by compiling the rom

in user mode and apply the patch in here (replacing test-keys by release.keys). This is an internal application (from my work).  I will look the link you mentioned.

Regards

#3 Updated by Andreas Blaesius almost 2 years ago

Yeah, switching to user builds makes sense because userdebug builds allow "adb root".

Testkeys vs releasekey might be a different thing you need for your work to mark it as safe Rom.

#4 Updated by Andreas Blaesius almost 2 years ago

  • Subject changed from Compiling espresso3g ua for android 6.0.1 (and upper) with BUILD_TYPE=user to Compiling ua with BUILD_TYPE=user
  • Status changed from New to In Progress
  • % Done changed from 0 to 50
  • Device deleted (espresso3g)

We'll switch to "user" builds on devices we feel they are stable enough, but it's in the end up to the maintainer.

Flo and Mako are switched now, espresso and espresso3g might follow soon.

We are not going to override BUILD_DISPLAY_ID and BUILD_VERSION_TAGS

#5 Updated by Jean Yves BAUDY almost 2 years ago

Andreas Blaesius wrote:

We'll switch to "user" builds on devices we feel they are stable enough, but it's in the end up to the maintainer.

Flo and Mako are switched now, espresso and espresso3g might follow soon.

We are not going to override BUILD_DISPLAY_ID and BUILD_VERSION_TAGS

Thanks for this update.

Regards

#6 Updated by Andreas Blaesius almost 2 years ago

  • Status changed from In Progress to Closed
  • Assignee set to Andreas Blaesius
  • % Done changed from 50 to 90

Like mentioned previously, our DM switch devices  to user builds if they feel they are stable enough. Espresso and espresso3g are switched to user on K & M, on N there's some work left before we can switch.

Also available in: Atom PDF